Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for const types #41

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Check for const types #41

merged 6 commits into from
Jun 14, 2024

Conversation

pableu
Copy link
Contributor

@pableu pableu commented Jun 10, 2024

Fixes #40.

My new code was heavily inspired by the implementation of the property_type rule.

@pableu
Copy link
Contributor Author

pableu commented Jun 10, 2024 •
edited
Loading

@TomasVotruba I was not sure whether to call the new classes and config options ...Constant..., ...Const...or ...ClassConst....

I went with Constant on a whim. Do you have a preference?

@pableu
Copy link
Contributor Author

pableu commented Jun 14, 2024

@TomasVotruba What do you think? 🙃

@TomasVotruba
Copy link
Owner

Looks good to me 👍 Thank for the features and making CI pass 💪

Let's ship it :)

@TomasVotruba TomasVotruba merged commit 8527a16 into TomasVotruba:main Jun 14, 2024
5 checks passed
@pableu
Copy link
Contributor Author

pableu commented Jun 14, 2024

Very cool. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Measure Type-Coverage for Class constants
2 participants
@pableu @TomasVotruba